geos
/
php-geos
6
6
Fork 4
Code Issues 5 Pull Requests 1 Releases Wiki Activity

PHP7 support #1

New Issue
Closed
opened 2016-07-19 04:34:39 -07:00 by strk · 3 comments
strk commented 2016-07-19 04:34:39 -07:00
Owner

Currently it is impossible to build the php bindings/extension for PHP7 (7.0.1) (Zend API changes).

Moved from https://trac.osgeo.org/geos/ticket/761

Currently it is impossible to build the php bindings/extension for PHP7 (7.0.1) (Zend API changes). Moved from https://trac.osgeo.org/geos/ticket/761
darkpanda commented 2016-07-21 15:44:13 -07:00
Collaborator

WIP branch is available at https://github.com/dark-panda/php-geos-native/tree/php7.

WIP branch is available at https://github.com/dark-panda/php-geos-native/tree/php7.
strk commented 2016-07-21 23:53:53 -07:00
Poster
Owner

I also pushed a work in progress in the php7 branch here:
https://git.osgeo.org/gogs/geos/php-geos/src/php7
my version is way less advanced and doesn't build yet for php7, but you may take a look if you find anything interesting (there are just a few changes).

Note that pushes into this repository are checked by an experimental self-hosted (by me) instance of Drone: https://drone.osgeo.kbt.io/geos/php-geos -- The builds are driven by .drone.yml which specifies using docker images built via scripts https://git.osgeo.org/gogs/geos/php-geos/src/master/docker/build-test. My plan is to also have PHP7 automatically tested (next to PHP5).

I also pushed a work in progress in the php7 branch here: https://git.osgeo.org/gogs/geos/php-geos/src/php7 my version is way less advanced and doesn't build yet for php7, but you may take a look if you find anything interesting (there are just a few changes). Note that pushes into this repository are checked by an experimental self-hosted (by me) instance of Drone: https://drone.osgeo.kbt.io/geos/php-geos -- The builds are driven by .drone.yml which specifies using docker images built via scripts https://git.osgeo.org/gogs/geos/php-geos/src/master/docker/build-test. My plan is to also have PHP7 automatically tested (next to PHP5).
strk commented 2016-07-22 02:26:22 -07:00
Poster
Owner

I've created a PR after advancing the branch to the point it builds with both PHP5 and PHP7 and seems to give the same test results as your branch. Let's continue the discussion in the PR: #2

I've created a PR after advancing the branch to the point it builds with both PHP5 and PHP7 and seems to give the same test results as your branch. Let's continue the discussion in the PR: #2
strk closed this issue 2016-07-22 02:26:22 -07:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
php8
master
drone1
1.0.0
1.0.0rc3
1.0.0rc2
1.0.0rc1
Labels
Clear labels   
Bug
   
Enhancement
No Label
Bug
Enhancement
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
strk
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: geos/php-geos#1
There is no content yet.
Delete Branch "%!s(<nil>)"

Deleting a branch is permanent. Although the deleted branch may exist for a short time before cleaning up, in most cases it CANNOT be undone. Continue?