GEOSWKBReader::read() throws ParseException when reading valid EWKB data on PHP 7 #12

New Issue

benmorel · 2016-12-10T15:29:32-08:00

benmorel commented

2016-12-10 15:29:32 -08:00

When using GEOSWKBReader, readHEX() works fine, but read() throws a ParseException for valid EWKB.

Example:

// SRID=4326; POINT (1 2)
$ewkb = '0101000020e6100000000000000000f03f0000000000000040';

$reader = new GEOSWKBReader();
$reader->readHEX($ewkb); // OK
$reader->read(hex2bin($ewkb)); // ParseException: Unexpected EOF parsing WKB

This only happens on PHP 7 and 7.1; on PHP 5.6, read() works fine.

When using `GEOSWKBReader`, `readHEX()` works fine, but `read()` throws a `ParseException` for valid EWKB. Example: // SRID=4326; POINT (1 2) $ewkb = '0101000020e6100000000000000000f03f0000000000000040'; $reader = new GEOSWKBReader(); $reader->readHEX($ewkb); // OK $reader->read(hex2bin($ewkb)); // ParseException: Unexpected EOF parsing WKB This only happens on PHP 7 and 7.1; on PHP 5.6, `read()` works fine.

strk commented

2016-12-11 01:17:36 -08:00

It looks like WKBReader tests are missing completely, would you send a PR to add them ?
See tests/003_WKTReader.phpt for an example.

It looks like WKBReader tests are missing completely, would you send a PR to add them ? See tests/003_WKTReader.phpt for an example.

benmorel commented

2016-12-11 05:01:33 -08:00

Poster

No problem, I'll PR some tests as soon as I have a chance!