length argument of the 's' specifier #7

Ghost · 2016-07-25T03:52:44-07:00

Ghost commented

2016-07-25 03:52:44 -07:00

i need these modifications otherwise the 001_Geometry-test fails.

strk commented

2016-07-25 08:13:31 -07:00

On which system does 001_Geometry fails ? Is it a 32bit system ?

strk commented

2016-07-25 10:31:37 -07:00

I tried to configure drone to test 32bit builds but it failed: https://drone.osgeo.kbt.io/geos/php-geos/26

Could you rebase your changes against current master, btw ?

I tried to configure drone to test 32bit builds but it failed: https://drone.osgeo.kbt.io/geos/php-geos/26 Could you rebase your changes against current master, btw ?

strk commented

2016-07-25 11:09:26 -07:00

Note that I pushed one of the commits in your branch

Ghost commented

2016-07-26 00:09:11 -07:00

Poster

I use a VM OpenSuse 13.2 64bit with PHP v7.0.8 debug.
Without my modifications i get a segfault:

Program received signal SIGSEGV, Segmentation fault.
0x00007ffff46622aa in strlen () from /lib64/libc.so.6
(gdb) bt
#0  0x00007ffff46622aa in strlen () from /lib64/libc.so.6
#1  0x00007fffe0838f05 in std::basic_string<char, std::char_traits<char>, std::allocator<char> >::basic_string(char const*, std::allocator<char> const&) () from /usr/lib64/libstdc++.so.6
#2  0x00007fffe0e417ae in GEOSRelatePattern_r (extHandle=0x16df7f0, g1=0x16e1800, g2=0x16e3da0, pat=<optimized out>) at geos_ts_c.cpp:728
#3  0x00007fffe1068588 in zim_Geometry_relate (execute_data=0x7ffff1a14700, return_value=0x7ffff1a14470) at /usr/src/php-geos/geos.c:1248
#4  0x00000000009ffd9e in ZEND_DO_FCALL_SPEC_HANDLER () at /usr/src/php-7.0.8/Zend/zend_vm_execute.h:842
#5  0x00000000009fec20 in execute_ex (ex=0x7ffff1a14030) at /usr/src/php-7.0.8/Zend/zend_vm_execute.h:414
#6  0x00000000009fed32 in zend_execute (op_array=0x7ffff1aad300, return_value=0x0) at /usr/src/php-7.0.8/Zend/zend_vm_execute.h:458
#7  0x00000000009a41e5 in zend_execute_scripts (type=8, retval=0x0, file_count=3) at /usr/src/php-7.0.8/Zend/zend.c:1427
#8  0x0000000000916d95 in php_execute_script (primary_file=0x7fffffffe0d0) at /usr/src/php-7.0.8/main/main.c:2494
#9  0x0000000000a6a818 in main (argc=2, argv=0x7fffffffe358) at /usr/src/php-7.0.8/sapi/cgi/cgi_main.c:2453

With my modifications all works fine.

Swen

I use a VM OpenSuse 13.2 64bit with PHP v7.0.8 debug. Without my modifications i get a segfault: ``` Program received signal SIGSEGV, Segmentation fault. 0x00007ffff46622aa in strlen () from /lib64/libc.so.6 (gdb) bt #0 0x00007ffff46622aa in strlen () from /lib64/libc.so.6 #1 0x00007fffe0838f05 in std::basic_string<char, std::char_traits<char>, std::allocator<char> >::basic_string(char const*, std::allocator<char> const&) () from /usr/lib64/libstdc++.so.6 #2 0x00007fffe0e417ae in GEOSRelatePattern_r (extHandle=0x16df7f0, g1=0x16e1800, g2=0x16e3da0, pat=<optimized out>) at geos_ts_c.cpp:728 #3 0x00007fffe1068588 in zim_Geometry_relate (execute_data=0x7ffff1a14700, return_value=0x7ffff1a14470) at /usr/src/php-geos/geos.c:1248 #4 0x00000000009ffd9e in ZEND_DO_FCALL_SPEC_HANDLER () at /usr/src/php-7.0.8/Zend/zend_vm_execute.h:842 #5 0x00000000009fec20 in execute_ex (ex=0x7ffff1a14030) at /usr/src/php-7.0.8/Zend/zend_vm_execute.h:414 #6 0x00000000009fed32 in zend_execute (op_array=0x7ffff1aad300, return_value=0x0) at /usr/src/php-7.0.8/Zend/zend_vm_execute.h:458 #7 0x00000000009a41e5 in zend_execute_scripts (type=8, retval=0x0, file_count=3) at /usr/src/php-7.0.8/Zend/zend.c:1427 #8 0x0000000000916d95 in php_execute_script (primary_file=0x7fffffffe0d0) at /usr/src/php-7.0.8/main/main.c:2494 #9 0x0000000000a6a818 in main (argc=2, argv=0x7fffffffe358) at /usr/src/php-7.0.8/sapi/cgi/cgi_main.c:2453 ``` With my modifications all works fine. Swen

strk commented

2016-07-26 01:16:41 -07:00

Can you please check if current master still needs modifications ?
The current build bot is a 64bit (docker) testing PHP-7.0.7 with gcc (Ubuntu 4.8.4-2ubuntu1~14.04.3) 4.8.4

Can you please check if current master still needs modifications ? The current build bot is a 64bit (docker) testing PHP-7.0.7 with gcc (Ubuntu 4.8.4-2ubuntu1~14.04.3) 4.8.4

Ghost commented

2016-07-26 02:11:04 -07:00

Poster

master works fine, no errors on my side :)

strk commented

2016-07-26 02:22:05 -07:00

Great, but now I'd love to get the problematic system automatically tested, somehow.
I could test PHP-7.0.8 to see if it makes a difference (7.0.7 is already built with --enable-debug but didn't fail). Latest is 7.0.9 if I'm not mistaken.

Great, but now I'd love to get the problematic system automatically tested, somehow. I could test PHP-7.0.8 to see if it makes a difference (7.0.7 is already built with --enable-debug but didn't fail). Latest is 7.0.9 if I'm not mistaken.

darkpanda commented

2016-07-26 13:10:38 -07:00

Can confirm, geometry tests were failing on OSX 10.11.5 with PHP 7.0.9 and GEOS 3.5.0, this PR fixes that.

strk closed this pull request

2016-07-28 03:32:28 -07:00

strk commented

2016-07-28 03:33:58 -07:00

thanks for testing, but I'm afraid I merged this to the wrong branch (now the code is in master).
@swen100 could you please file a new PR targetting the master branch, if still needed ?

thanks for testing, but I'm afraid I merged this to the wrong branch (now the code is in master). @swen100 could you please file a new PR targetting the master branch, if still needed ?

Sign in to join this conversation.

No reviewers

No Label

Bug

Enhancement

No Milestone

No Assignees

3 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: geos/php-geos#7