postgis
/
postgis
12
5
Fork 24
Code Issues Pull Requests 16 Wiki Activity

Have dronie/woodie check cross-version upgrades in locking mode #145

Closed
strk wants to merge 6 commits from strk:locked-upgrades into master
pull from: strk:locked-upgrades
merge into: postgis:master
Conversation 2 Commits 6 Files Changed 9
strk commented 2023-08-30 12:51:08 -07:00
Owner

References #5516
References #5517
References #5497

References #5516 References #5517 References #5497
strk force-pushed locked-upgrades from b2582eee8c to 7bd89a34da 2023-08-31 01:15:20 -07:00 Compare
strk force-pushed locked-upgrades from 7bd89a34da to 5e91f595ee 2023-08-31 01:17:05 -07:00 Compare
strk force-pushed locked-upgrades from 5e91f595ee to f04a2c72ba 2023-08-31 03:18:09 -07:00 Compare
strk force-pushed locked-upgrades from f04a2c72ba to 8f30ec5341 2023-08-31 13:18:41 -07:00 Compare
strk force-pushed locked-upgrades from 8f30ec5341 to f7d516632d 2023-08-31 14:08:23 -07:00 Compare
strk force-pushed locked-upgrades from f7d516632d to 980b464926 2023-08-31 14:36:24 -07:00 Compare
strk force-pushed locked-upgrades from 3fc288d7cc to 79ea176e09 2023-08-31 16:13:54 -07:00 Compare
strk force-pushed locked-upgrades from abf17ba4ce to 6d7827b3c7 2023-09-01 01:06:50 -07:00 Compare
strk force-pushed locked-upgrades from 6d7827b3c7 to e4a9c3c809 2023-09-01 01:08:57 -07:00 Compare
strk force-pushed locked-upgrades from d841b4038c to e2d3c6dfda 2023-09-01 02:22:21 -07:00 Compare
strk commented 2023-09-01 03:55:31 -07:00
Poster
Owner

Next failure is due to the legacy.sql test which break uninstall because it leaves behind a lot of functions:
https://woodie.osgeo.org/repos/30/pipeline/938/9#L8628

It seems to be due to an error interrupting the transaction:


-----------------------------------------------------------------------------
--- regress/core/legacy_expected        2023-09-01 07:52:46.900420710 +0000
+++ /tmp/pgis_reg/test_1_out    2023-09-01 10:45:13.215427704 +0000
@@ -1,3 +1,4 @@
+ERROR:  cannot change name of input parameter "gj_version"
 Starting up MapServer/Geoserver tests...
 Setting up the data table...
 public.wmstest.pt SRID:4326 TYPE:POLYGON DIMS:2
@@ -17,3 +18,6 @@
 Removing the data table...
 Done.
 1869|POINT(1 2)
+ERROR:  cannot drop function st_asgeojson(integer,geometry,integer,integer) because extension postgis requires it
+ERROR:  current transaction is aborted, commands ignored until end of transaction block
+ERROR:  current transaction is aborted, commands ignored until end of transaction block
-----------------------------------------------------------------------------

In turn that's due to:

postgis/legacy.sql:2160: ERROR:  cannot change name of input parameter "gj_version"
HINT:  Use DROP FUNCTION st_asgeojson(integer,geometry,integer,integer) first.
Next failure is due to the legacy.sql test which break uninstall because it leaves behind a lot of functions: https://woodie.osgeo.org/repos/30/pipeline/938/9#L8628 It seems to be due to an error interrupting the transaction: ``` ----------------------------------------------------------------------------- --- regress/core/legacy_expected 2023-09-01 07:52:46.900420710 +0000 +++ /tmp/pgis_reg/test_1_out 2023-09-01 10:45:13.215427704 +0000 @@ -1,3 +1,4 @@ +ERROR: cannot change name of input parameter "gj_version" Starting up MapServer/Geoserver tests... Setting up the data table... public.wmstest.pt SRID:4326 TYPE:POLYGON DIMS:2 @@ -17,3 +18,6 @@ Removing the data table... Done. 1869|POINT(1 2) +ERROR: cannot drop function st_asgeojson(integer,geometry,integer,integer) because extension postgis requires it +ERROR: current transaction is aborted, commands ignored until end of transaction block +ERROR: current transaction is aborted, commands ignored until end of transaction block ----------------------------------------------------------------------------- ``` In turn that's due to: ``` postgis/legacy.sql:2160: ERROR: cannot change name of input parameter "gj_version" HINT: Use DROP FUNCTION st_asgeojson(integer,geometry,integer,integer) first. ```
strk force-pushed locked-upgrades from 31130d4463 to e970a5c446 2023-09-01 05:00:35 -07:00 Compare
strk force-pushed locked-upgrades from e970a5c446 to a770c92988 2023-09-01 05:13:24 -07:00 Compare
strk force-pushed locked-upgrades from a770c92988 to d3e525ee45 2023-09-01 05:42:50 -07:00 Compare
strk force-pushed locked-upgrades from d3e525ee45 to c1c6f4af0c 2023-09-01 06:20:32 -07:00 Compare
strk commented 2023-09-01 06:22:40 -07:00
Poster
Owner

Fully merged in master as of 36bc628269

Fully merged in master as of 36bc628269f2324f8fae82b588466b8633b8fd63
strk closed this pull request 2023-09-01 06:22:41 -07:00
strk deleted branch locked-upgrades 2023-09-01 06:22:50 -07:00
Some checks reported errors
ci/woodpecker/pr/docs Pipeline was successful
Details
ci/woodpecker/pr/tools Pipeline failed
Details
ci/woodpecker/pr/regress Pipeline failed
Details
continuous-integration/drone/pr Build was killed
Details

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
bug fix
   
changes requested
   
enhancement
   
needs NEWS
   
needs rebase
   
needs ticket
   
new feature
   
work in progress
No Label
bug fix
changes requested
enhancement
needs NEWS
needs rebase
needs ticket
new feature
work in progress
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: postgis/postgis#145
There is no content yet.
Delete Branch "strk:locked-upgrades"

Deleting a branch is permanent. Although the deleted branch may exist for a short time before cleaning up, in most cases it CANNOT be undone. Continue?