postgis
/
postgis
12
5
Fork 24
Code Issues Pull Requests 16 Wiki Activity

Bump SFCGAL to 1.4.0 and CGAL to 5.3 #56

Closed
lbartoletti wants to merge 1 commits from lbartoletti:bump_sfcgal_to_1.4.0 into master
pull from: lbartoletti:bump_sfcgal_to_1.4.0
merge into: postgis:master
Conversation 8 Commits 1 Files Changed 4
lbartoletti commented 2021-09-19 21:53:30 -07:00
Collaborator

@robe I suggest using the latest version of SFCGAL (and CGAL) which uses the stable (I hope) version of the CGAL API.

@robe I suggest using the latest version of SFCGAL (and CGAL) which uses the stable (I hope) version of the CGAL API.
lbartoletti added 1 commit 2021-09-19 21:53:35 -07:00
continuous-integration/drone/pr Build is passing Details
d960307082 Bump SFCGAL to 1.4.0 and CGAL to 5.3
robe commented 2021-09-20 06:35:55 -07:00
Owner

Okay. FYI the settings for debbie are remarked out because she uses the system installed SFCGAL which for bullseye appears to be SFCGAL 1.3.8/CGAL 5.2. For winnie I do compile SFCGAL so can do that. Any suggestions on version of Boost to use?

Okay. FYI the settings for debbie are remarked out because she uses the system installed SFCGAL which for bullseye appears to be SFCGAL 1.3.8/CGAL 5.2. For winnie I do compile SFCGAL so can do that. Any suggestions on version of Boost to use?
lbartoletti commented 2021-09-20 22:24:41 -07:00
Poster
Collaborator

Any suggestions on version of Boost to use?

AFAIK, >= 1.71.0 is a good choice

> Any suggestions on version of Boost to use? AFAIK, >= 1.71.0 is a good choice
robe commented 2021-09-21 05:01:27 -07:00
Owner

Okay that's good I think on winnie I have boost 1.73 so guess I'll keep that.

That said is CGAL 5.3 required for SFCGAL master now? I thought that was just a preferred.

Related ticket our docker image builds for github actions are failing.

See related ticket:

https://github.com/postgis/postgis-build-env/issues/20

If it's required I can downgrade until I can switch back to building with debian-unstable or just build CGAL as part of the build. I had switched to debian-stable because of this https://github.com/OSGeo/gdal/issues/4341

Okay that's good I think on winnie I have boost 1.73 so guess I'll keep that. That said is CGAL 5.3 required for SFCGAL master now? I thought that was just a preferred. Related ticket our docker image builds for github actions are failing. See related ticket: https://github.com/postgis/postgis-build-env/issues/20 If it's required I can downgrade until I can switch back to building with debian-unstable or just build CGAL as part of the build. I had switched to debian-stable because of this https://github.com/OSGeo/gdal/issues/4341
lbartoletti commented 2021-09-22 09:23:45 -07:00
Poster
Collaborator

That said is CGAL 5.3 required for SFCGAL master now? I thought that was just a preferred.

It's a hard preference ; it no longer uses obscure, undocumented and unstable APIs. It could build with CGAL 5.2/5.1 but some functions may have a slightly different result.

> That said is CGAL 5.3 required for SFCGAL master now? I thought that was just a preferred. It's a hard preference ; it no longer uses obscure, undocumented and unstable APIs. It could build with CGAL 5.2/5.1 but some functions may have a slightly different result.
lbartoletti commented 2021-09-22 09:27:06 -07:00
Poster
Collaborator

just build CGAL as part of the build.

You can use this part of the cgal installation in your CI:

https://gitlab.com/Oslandia/SFCGAL/-/blob/master/ci/debian/before_install.sh#L11-13

BTW, I can also add a SFCGAL postgis test in our CI.

> just build CGAL as part of the build. You can use this part of the cgal installation in your CI: https://gitlab.com/Oslandia/SFCGAL/-/blob/master/ci/debian/before_install.sh#L11-13 BTW, I can also add a SFCGAL postgis test in our CI.
robe commented 2021-09-22 09:36:29 -07:00
Owner

just build CGAL as part of the build.

You can use this part of the cgal installation in your CI:

https://gitlab.com/Oslandia/SFCGAL/-/blob/master/ci/debian/before_install.sh#L11-13

BTW, I can also add a SFCGAL postgis test in our CI.

Okay will do since cgal is header only and it builds sfcgal any way will not add much overhead

> > just build CGAL as part of the build. > > You can use this part of the cgal installation in your CI: > > https://gitlab.com/Oslandia/SFCGAL/-/blob/master/ci/debian/before_install.sh#L11-13 > > BTW, I can also add a SFCGAL postgis test in our CI. Okay will do since cgal is header only and it builds sfcgal any way will not add much overhead
robe commented 2021-09-23 00:37:26 -07:00
Owner

Took care of github actions builds with this commit

c9588ce5a4

I'm not sure why CGAL_DIR wasn't sufficient. It is for me when building under windows. Had to add the -DCMAKE_PREFIX_PATH=/src/CGAL

anyway I think all envs that can run with CGAL 5.3/SFCGAL 1.4/master are done.

Took care of github actions builds with this commit https://github.com/postgis/postgis-build-env/commit/c9588ce5a44bf1d83277cd3f2e06394b45a63456 I'm not sure why CGAL_DIR wasn't sufficient. It is for me when building under windows. Had to add the -DCMAKE_PREFIX_PATH=/src/CGAL anyway I think all envs that can run with CGAL 5.3/SFCGAL 1.4/master are done.
robe closed this pull request 2021-09-23 00:37:26 -07:00
lbartoletti commented 2021-09-27 05:00:07 -07:00
Poster
Collaborator

Thanks @robe

Thanks @robe
lbartoletti deleted branch bump_sfcgal_to_1.4.0 2021-09-27 05:00:12 -07:00
All checks were successful
continuous-integration/drone/pr Build is passing
Details

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
bug fix
   
changes requested
   
enhancement
   
needs NEWS
   
needs rebase
   
needs ticket
   
new feature
   
work in progress
No Label
bug fix
changes requested
enhancement
needs NEWS
needs rebase
needs ticket
new feature
work in progress
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: postgis/postgis#56
There is no content yet.
Delete Branch "lbartoletti:bump_sfcgal_to_1.4.0"

Deleting a branch is permanent. Although the deleted branch may exist for a short time before cleaning up, in most cases it CANNOT be undone. Continue?