Handle symbolic refs in post-receive-email #1

New Issue

strk · 2021-07-01T11:15:52-07:00

strk commented

2021-07-01 11:15:52 -07:00

When symbolic refs are in use (like master == main) commit email do not contain the diffs anymore.

I think the culprit is in the show_new_revisions function of the post-receive-email script, which tries to find which revisions are not accessible in other refs (while not skipping the symbolic refs)

It's in this snippet:

        other_branches=$(git for-each-ref --format='%(refname)' refs/heads/ |
            grep -F -v $refname)
        git rev-parse --not $other_branches |
        if [ -z "$custom_showrev" ]
        then
                git rev-list --pretty --stdin $revspec
        else
                git rev-list --stdin $revspec |
                while read onerev
                do
                        eval $(printf "$custom_showrev" $onerev)
                done
        fi

This could maybe be fixed by massaging the output of for-each-ref to rename symbolic refs to their proper name...

Affected projects:

Postgis - https://trac.osgeo.org/postgis/ticket/4937
GEOS - https://trac.osgeo.org/geos/ticket/1120

Note that the GEOS project fixed this by dropping the symbolic ref

When symbolic refs are in use (like master == main) commit email do not contain the diffs anymore. I think the culprit is in the `show_new_revisions` function of the `post-receive-email` script, which tries to find which revisions are not accessible in other refs (while not skipping the symbolic refs) It's in this snippet: ``` other_branches=$(git for-each-ref --format='%(refname)' refs/heads/ | grep -F -v $refname) git rev-parse --not $other_branches | if [ -z "$custom_showrev" ] then git rev-list --pretty --stdin $revspec else git rev-list --stdin $revspec | while read onerev do eval $(printf "$custom_showrev" $onerev) done fi ``` This could maybe be fixed by massaging the output of `for-each-ref` to rename symbolic refs to their proper name... Affected projects: - Postgis - https://trac.osgeo.org/postgis/ticket/4937 - GEOS - https://trac.osgeo.org/geos/ticket/1120 Note that the GEOS project fixed this by dropping the symbolic ref

strk referenced this issue from a commit

2021-07-01 11:26:16 -07:00

Do not look into symrefs for known revisions Fixes #1

strk closed this issue

2021-07-01 11:28:11 -07:00

strk commented

2021-07-01 11:43:14 -07:00

Poster

Confirmed it works again:
https://lists.osgeo.org/pipermail/postgis-tickets/2021-July/023868.html

Confirmed it works again: https://lists.osgeo.org/pipermail/postgis-tickets/2021-July/023868.html

strk referenced this issue from a commit

2021-07-01 15:14:54 -07:00